Minor fixes#2214
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the composefs_gc function to accept a new GCOpts struct instead of separate boolean parameters, improving code readability and maintainability. Additionally, it optimizes the get_bootloader function by caching the detected bootloader in a OnceLock to avoid redundant UEFI variable reads. The feedback suggests deriving standard traits (Debug, Clone, Copy, PartialEq, Eq) on the new GCOpts struct and simplifying the get_bootloader implementation by removing redundant .clone() calls and utilizing idiomatic Rust patterns.
We use the `get_bootloader` function frequently and the value will never change so just cache it Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
Update function signature for `composefs_gc` to take in a `GCOpts` struct with named fields instead of two booleans Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
Johan-Liebert1
force-pushed
the
minor-fixes
branch
from
233f588 to
e426ab9
Compare
cgwalters
approved these changes
May 26, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
OnceLockto store the detected bootloaderWe use the
get_bootloaderfunction frequently and the value will neverchange so just cache it
composefs/gc: Change function signature
Update function signature for
composefs_gcto take in aGCOptsstruct with named fields instead of two booleans